Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test suite to use Test Resources #701

Merged

Conversation

jeremyg484
Copy link
Contributor

Refactors the entire test suite to use Test Resources. This significantly reduces the time it takes to run the test suite, making it easier to work on additional features.

Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@sdelamo
Copy link
Contributor

sdelamo commented Apr 25, 2023

@jeremyg484 please investigate the CI failures

@jeremyg484
Copy link
Contributor Author

jeremyg484 commented Apr 25, 2023

Down to 1 failing test in CI (cannot reproduce locally so far) - one of the features in KafkaShutdownHandlingSpec. Given the nature of the test, I suspect it is a timing issue. I will continue to investigate it tomorrow - looking for a way to reproduce and/or make it more reliable.

@jeremyg484
Copy link
Contributor Author

@sdelamo I re-worked the failing CI tests and it looks like everything is green now.

@graemerocher graemerocher merged commit df34580 into micronaut-projects:master Apr 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants