Catch record deserialization exceptions that may happen while polling #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyg484
reviewed
Jul 13, 2023
kafka/src/main/java/io/micronaut/configuration/kafka/processor/KafkaConsumerProcessor.java
Show resolved
Hide resolved
sdelamo
reviewed
Jul 19, 2023
kafka/src/test/groovy/io/micronaut/configuration/kafka/errors/KafkaErrorStrategySpec.groovy
Show resolved
Hide resolved
sdelamo
approved these changes
Jul 19, 2023
jeremyg484
approved these changes
Jul 19, 2023
guillermocalvo
deleted the
640-messages-not-reprocessed-by-consumer-when-serializationexception-occurs-while-producing-message
branch
guillermocalvo
added a commit
to giamo/micronaut-kafka
that referenced
this pull request
Aug 4, 2023
Previous behavior was buggy. It was fixed by: micronaut-projects#771
sdelamo
pushed a commit
that referenced
this pull request
Aug 18, 2023
* Allow to commit offset in case of serialization errors * Disable test kafka listeners unless running their specific test * Add documentation * Update test to reflect current behavior Previous behavior was buggy. It was fixed by: #771 * Create config classes for the default kafka listener exception handler * Update documentation * Add an empty, `@Deprecated` constructor --------- Co-authored-by: Guillermo Calvo <calvog@objectcomputing.com> Co-authored-by: Guillermo Calvo <guillermo@guillermo.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #640