Multi-language documentation for Forwarding Messages with @SendTo example #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could probably use some tests, although these docs examples never had any to begin with. |
…uld be groovier, Kotlin was great 😀
sdelamo
requested changes
Aug 21, 2023
...-suite-groovy/src/test/groovy/io/micronaut/kafka/docs/consumer/sendto/ProductListener.groovy
Outdated
Show resolved
Hide resolved
test-suite-kotlin/src/test/kotlin/io/micronaut/kafka/docs/consumer/sendto/ProductListener.kt
Outdated
Show resolved
Hide resolved
test-suite-groovy/src/test/groovy/io/micronaut/kafka/docs/consumer/sendto/WordCounter.groovy
Show resolved
Hide resolved
test-suite-kotlin/src/test/kotlin/io/micronaut/kafka/docs/consumer/sendto/WordCounter.kt
Show resolved
Hide resolved
test-suite/src/test/java/io/micronaut/kafka/docs/consumer/sendto/WordCounter.java
Show resolved
Hide resolved
test-suite/src/test/java/io/micronaut/kafka/docs/consumer/sendto/ProductListener.java
Outdated
Show resolved
Hide resolved
no, still meeds tests |
guillermocalvo
suggested changes
Aug 28, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
guillermocalvo
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.