Return ScheduledExecutorService from ConsumerExecutorServiceConfig #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… per documentation (and documented behaviour). This change should be forward compatible as ScheduledExecutorService is a subtype of ExecutorService and implements all of the base functionality.
Return ScheduledExecutorService from ConsumerExecutorServiceConfig
guillermocalvo
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with documented behaviour.
This change should be forward compatible as
ScheduledExecutorServiceis a subtype ofExecutorServiceand implements all of the base functionality.Also of note: the
ExecutorConfigurationreturn does not have it's name field configured toconsumeras one would expect, although the bean is@Named("consumer")