Remove annotation @Internal from class JsonObjectSerde
#849
Conversation
|
@dstepanov added you since you added the annotation |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Why does it need to be "public"? |
Because documentation says it can be subclassed:
|
|
In what way would you do it? |
I'd say either we stop discouraging users from using this class (ie. remove It all depends on what motivated the addition of this annotation in the first place. @dstepanov What was the rationale behind it? |
|
I just don’t understand how it can be extended and used to register anything. If you thinks the use case is valid go ahead and remove the internal. My motivation was to not expose internal classes as over API. |
If you believe this is really an internal class that shouldn't be directly subclassed by users, I can just remove that part of the guide. I'm good either way. Your call @dstepanov |
|
it seems to me that to customize kafka serialization, subclassing JsonObjectSerde and overriding the read/write methods makes sense. but we have no sample of this. @graemerocher you wrote this initially, do you remember how it's supposed to be used? @henriquelsmti can you share what you do in your subclass? |
|
@yawkat after some refactoring, we'r using JsonObjectSerde only in kafka streams, as a superclass for Serdes of specific types. |
|
There seem to be valid use cases for subclassing |
|
If it’s a valid case then yes |
No description provided.