Auto-create topic with N partitions #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
requested changes
Sep 25, 2023
kafka/src/main/java/io/micronaut/configuration/kafka/admin/KafkaNewTopics.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/admin/KafkaNewTopics.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/admin/KafkaNewTopics.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/admin/KafkaNewTopics.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/admin/KafkaNewTopics.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/admin/KafkaNewTopics.java
Outdated
Show resolved
Hide resolved
dstepanov
reviewed
Sep 26, 2023
| */ | ||
| @Context | ||
| @Requires(bean = AdminClient.class) | ||
| public class KafkaNewTopics { |
There was a problem hiding this comment.
Does it need to be public?
There was a problem hiding this comment.
Yes it does. Users may need to retrieve CreateTopicsResult from it.
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
guillermocalvo
commented
Sep 26, 2023
kafka/src/main/java/io/micronaut/configuration/kafka/admin/KafkaNewTopics.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
guillermocalvo
commented
Sep 26, 2023
kafka/src/main/java/io/micronaut/configuration/kafka/admin/KafkaNewTopics.java
Outdated
Show resolved
Hide resolved
guillermocalvo
commented
Sep 26, 2023
kafka/src/test/groovy/io/micronaut/configuration/kafka/admin/KafkaNewTopicsSpec.groovy
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
sdelamo
approved these changes
Sep 29, 2023
|
ping @dstepanov |
dstepanov
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.