Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for batch Acknowledgement #887

Merged

Conversation

guillermocalvo
Copy link
Contributor

Based on: #692

Based-on: #692
Co-authored-by: Jeremy Grelle <grellej@unityfoundation.io>
@guillermocalvo guillermocalvo linked an issue Oct 2, 2023 that may be closed by this pull request
@guillermocalvo guillermocalvo added the type: improvement A minor improvement to an existing feature label Oct 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sdelamo
Copy link
Contributor

sdelamo commented Oct 3, 2023

@jeremyg484 please review

@sdelamo sdelamo merged commit dbb2469 into master Nov 9, 2023
8 checks passed
@sdelamo sdelamo deleted the 54-batch-and-acknowledgement-are-mutually-exclusive branch November 9, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Batch and Acknowledgement are mutually exclusive
3 participants