Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Netty version once it's updated on core #134

Closed
ilopmar opened this issue Aug 25, 2020 · 4 comments · Fixed by #187
Closed

Update Netty version once it's updated on core #134

ilopmar opened this issue Aug 25, 2020 · 4 comments · Fixed by #187
Labels
status: pr submitted A pull request has been submitted for the issue type: task A task that needs to be completed

Comments

@ilopmar
Copy link
Contributor

ilopmar commented Aug 25, 2020

Once micronaut-core is updated to Netty 4.1.52 (or another one), revert this change #133 and update version in this module.
@ilopmar ilopmar added the type: task A task that needs to be completed label Aug 25, 2020
@alvarosanchez
Copy link
Member

Can we not remove the nettyVersion property from here and use the one from micronaut-core?

micronaut-bom imports netty-bom, which should resolve all io.netty dependencies.

@ilopmar
Copy link
Contributor Author

ilopmar commented Dec 2, 2020

Probably. I think the problem was that we were not able to upgrade Netty in core (because of some regressions they had in different versions) and we wanted to make sure we were using the same version here. If we don't pin the version here dependabot/dependency-upgrade will upgrade the version here. Then, in users' apps with micrometer the new netty version would be used, leading to issues.

@ilopmar
Copy link
Contributor Author

ilopmar commented Dec 2, 2020

Btw, at this moment it's safe to upgrade to the same one using in core (4.1.54 I believe)

@alvarosanchez
Copy link
Member

Right. Dependabot will attempt to upgrade the version if you have one defined explicitly. If you omit it and let it be resolved from the BOM, it should do nothing.

Will try that approach

alvarosanchez added a commit that referenced this issue Dec 2, 2020
@alvarosanchez
Remove nettyVersion.
3e16b66 
Closes #134
@alvarosanchez alvarosanchez mentioned this issue Dec 2, 2020
Merged
@alvarosanchez alvarosanchez added the status: pr submitted A pull request has been submitted for the issue label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pr submitted A pull request has been submitted for the issue type: task A task that needs to be completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove nettyVersion. micronaut-projects/micronaut-micrometer
2 participants
@alvarosanchez @ilopmar