Multiple implementations of Subdomain tenant resolver supporting every domain suffix #234
Conversation
sdelamo
added
type: improvement
.../src/main/java/io/micronaut/multitenancy/tenantresolver/AbstractSubdomainTenantResolver.java
Outdated
Show resolved
Hide resolved
...n/java/io/micronaut/multitenancy/tenantresolver/PublicSuffixListSubdomainTenantResolver.java
Outdated
Show resolved
Hide resolved
| return TenantResolver.DEFAULT; | ||
| protected Serializable resolveSubdomain(@NonNull String host) { | ||
| if (host.chars().filter(ch -> ch == '.').count() > 1) { | ||
| return host.substring(0, host.indexOf(".")); |
There was a problem hiding this comment.
This will return only the last subdomain:
- ✅
test.comresolves to:DEFAULT - ✅
duper.test.comresolves to:duper - ❗
super.duper.test.comresolves to:super- Should be:
super.duper
- Should be:
There was a problem hiding this comment.
I added a test 2d717f8
…olver/AbstractSubdomainTenantResolver.java Co-authored-by: Guillermo Calvo <guillermocalvo@gmail.com>
…olver/PublicSuffixListSubdomainTenantResolver.java Co-authored-by: Guillermo Calvo <guillermocalvo@gmail.com>
Not sure what you mean, we have some tests: https://github.com/micronaut-projects/micronaut-multitenancy/blob/guava-compile-only/multitenancy/src/test/groovy/io/micronaut/multitenancy/tenantresolver/SubdomainTenantResolverEnabledSpec.groovy#L83-L92 |
|
Kudos, SonarCloud Quality Gate passed! |
@sdelamo You fixed the implementation here. Previously, it was simply returning |
Close: #225 #73