Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoints with OPTION method not added to generated OpenAPI spec #1246

Closed
jayeshkapadnis opened this issue Oct 10, 2023 · 5 comments · Fixed by #1248
Closed

Endpoints with OPTION method not added to generated OpenAPI spec #1246

jayeshkapadnis opened this issue Oct 10, 2023 · 5 comments · Fixed by #1248

Comments

@jayeshkapadnis
Copy link

Issue description

I am trying to upgrade my application from Micronaut version 3.8.7 to 4.1.3.

We use micronaut-openapi to generate specs yaml. We have few apis with Http Method OPTION to ensure we can add an extension details to it.

With changes as part of PR #1067, when SchemaUtils.setOperationOnPathItem is invoked it doesn't consider any HttpMethods from HEAD, OPTIONS & TRACE. Earlier it was part of AbstractOpenApiEndpointVisitor.setOperationOnPathItem.

Is there a specific reason to remove these ? Is there any workaround to include endpoints with these methods in generated OpenAPI spec ?
altro3 added a commit to altro3/micronaut-openapi that referenced this issue Oct 11, 2023
@altro3
Added lost http methods
7f0bf6a 
Fixed micronaut-projects#1246
@altro3 altro3 mentioned this issue Oct 11, 2023
Merged
@altro3
Copy link
Collaborator

altro3 commented Oct 11, 2023

No, it's just a bug. Fixed here: #1248

@jayeshkapadnis
Copy link
Author

Thank you for the quick response.

graemerocher pushed a commit that referenced this issue Oct 12, 2023
@altro3
Added lost http methods (#1248)
e0a7893 
Fixed #1246
@jayeshkapadnis
Copy link
Author

Hi @altro3, when are you planning to release this fix ?

@altro3
Copy link
Collaborator

altro3 commented Oct 25, 2023

@jayeshkapadnis hi! Hm... I don't know when next released planned, but I thought that we can wait micronaut core 4.2.0 release and also fix KSP support. Also I want to release these new features - #1254 and #1233

@jayeshkapadnis
Copy link
Author

Thanks for the info @altro3 . I will hot fix this for now in my project, till it's released. Looking forward to #1254 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added lost http methods altro3/micronaut-openapi
2 participants
@jayeshkapadnis @altro3