Add process WildcardElement and GenericPlaceholderElement (4.10) #1133
Conversation
altro3
force-pushed
the
fix_wildcards_4.10
branch
from
efcd171
to
201c3bc
Compare
| Boolean isArray = null; | ||
| Boolean isIterable = null; | ||
|
|
||
| ClassElement componentType = type != null ? type.getFirstTypeArgument().orElse(null) : null; |
There was a problem hiding this comment.
I don’t think you need to know if the element is generic or not, the actual type should represent the most upper one
There was a problem hiding this comment.
Don't agree. Without this changes this test will be failed:
@Get("/get1")
public <T extends Channel> String index1(@Nullable @QueryValue T[] channels) {
return null;
}There was a problem hiding this comment.
Why exactly? It will not return that it’s an array?
There was a problem hiding this comment.
Because I'm expecting to see an EnumElement, but I get GenericPlacehoderElement, so the processing goes the wrong way. If I comment this code, problem will be in red line:
I suspect that the problem arises only with enums
There was a problem hiding this comment.
I think we should have something like asEnum(), we have to complicated hierarchy
There was a problem hiding this comment.
Well, but I think at the moment this fix is quite correct and should be merged
altro3
changed the title
Fixed #1131