Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for generating openAPI clients #1467

Merged

Conversation

altro3
Copy link
Collaborator

@altro3 altro3 commented Mar 6, 2024

  • Add ability to disable generating path attribute in Client annotation
  • Changed basePathSeparator default value to . symbol
  • Add suffixes by clientId to client base path placeholders

With clientId it will be:

@Client("myclient")

But you could set clientPath = true and you will see this:

@Client(id = "myclient", path = "${myclient.base-path}")

Without client id it will be

@Client("${openapi-micronaut-client.base-path}")

@altro3
Copy link
Collaborator Author

altro3 commented Mar 6, 2024

 - Add ability to disable generating `path` attribute in Client annotation
 - Changed basePathSeparator default value to `.` symbol
 - Add suffixes by class-name or clientId to client base path placeholders
@altro3 altro3 force-pushed the fix-generating-multiple-api-clients branch from f820716 to 6d5f0ea Compare March 7, 2024 09:38
@sdelamo sdelamo merged commit f5b0101 into micronaut-projects:master Mar 19, 2024
6 checks passed
timyates added a commit to micronaut-projects/micronaut-maven-plugin that referenced this pull request Apr 18, 2024
In 6.7.0 a the base-url property was renamed to have a dot separator instead of hyphen.

micronaut-projects/micronaut-openapi#1467

We are doing this in a patch release as it is an ongoing bug in Micronaut 4.4.0 and will be released with 4.4.1.
timyates added a commit to micronaut-projects/micronaut-maven-plugin that referenced this pull request Apr 18, 2024
* Update openapi version to 6.8.0

In 6.7.0 a the base-url property was renamed to have a dot separator instead of hyphen.

micronaut-projects/micronaut-openapi#1467

We are doing this in a patch release as it is an ongoing bug in Micronaut 4.4.0 and will be released with 4.4.1.

* Prepare for 4.5.3 release

* Switch to use micronaut 4.4.0 for integration tests

* Cleanup

* Fix crac-aot integration test

* 6.7.0 to align with the Gradle plugin
github-merge-queue bot pushed a commit to micronaut-projects/micronaut-maven-plugin that referenced this pull request Apr 23, 2024
* Update openapi version to 6.7.0 (#1078)

* Update openapi version to 6.8.0

In 6.7.0 a the base-url property was renamed to have a dot separator instead of hyphen.

micronaut-projects/micronaut-openapi#1467

We are doing this in a patch release as it is an ongoing bug in Micronaut 4.4.0 and will be released with 4.4.1.

* Prepare for 4.5.3 release

* Switch to use micronaut 4.4.0 for integration tests

* Cleanup

* Fix crac-aot integration test

* 6.7.0 to align with the Gradle plugin

* [maven-release-plugin] prepare release v4.5.3

* [maven-release-plugin] prepare for next development iteration

---------

Co-authored-by: Tim Yates <tim.yates@gmail.com>
Co-authored-by: micronaut-build <micronaut-build-account@grails.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants