bug: serialization agnostic #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
wetted
approved these changes
Jul 20, 2023
timyates
added a commit
to micronaut-projects/micronaut-mqtt
that referenced
this pull request
Jan 9, 2024
mqtt-core was based on serde-jackson which may be missing if the consuming project is using jackson. This change mirrors the fix for problem-json here micronaut-projects/micronaut-problem-json#293 That is, make the serde-api and jackson annotations api dependencies of this project in place of the serde-jackson dependency. I have an external reproducer, but I cannot get it to fail when included in this project... Closes #332
sdelamo
pushed a commit
to micronaut-projects/micronaut-mqtt
that referenced
this pull request
Jan 9, 2024
* Fix MQTT with Jackson mqtt-core was based on serde-jackson which may be missing if the consuming project is using jackson. This change mirrors the fix for problem-json here micronaut-projects/micronaut-problem-json#293 That is, make the serde-api and jackson annotations api dependencies of this project in place of the serde-jackson dependency. I have an external reproducer, but I cannot get it to fail when included in this project... Closes #332 * Add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #291 #257