graalvm workflow modifications #359
Conversation
deleted graalvm.yml added graalvm-latest.yml (executes only native tests by 'latest' graalvm for PRs and merges to master) added graalvm-dev.yml (executes only native tests by 'dev' graalvm once a day)
.github/workflows/graalvm-base.yml
Outdated
| if ./gradlew tasks --no-daemon --all | grep -w "nativeTest" | ||
| then | ||
| ./gradlew nativeTest --no-daemon --continue | ||
| fi |
There was a problem hiding this comment.
I think @melix once said there was a better way to do this
There was a problem hiding this comment.
We can basically remove this once every project has moved out of the legacy nativeTest task, which should be the case by now?
There was a problem hiding this comment.
We can't remove that since not all modules in a project have nativeTest task. So far we had dependency between the check and nativeTest gradle tasks and when we executed the check task we didn't have to worry whether module has nativeTest task or not, but now we want to remove that dependency and to execute only nativeTest tasks in this workflow.
|
This is an interesting way of reusing workflows. At micronaut-projects/micronaut-kubernetes#534, @n0tl3ss tried differently by using reusable worklfows. I'd leave to you both to decide which one is better |
|
This implementation is also based on reusable worklfows. |
…-projects/github-actions`
|
The last thing to consider: the graalvm-dev and graalvm-latest workflows should be synced only once. When all the repos have received the sync PR, we need to ignore them from the sync list. And the same think should be done with the Gradle workflow. Would you please create an issue to not forget about it? |
|
@alvarosanchez: I created a new issue: #360 |
Modifications:
New workflows are using github composite actions from https://github.com/micronaut-projects/github-actions.
NOTE: This PR should be merged to master after this PR: micronaut-projects/github-actions#26