Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TracingInterceptor tests fails in Micronaut Reactor #296

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Jun 5, 2023

No description provided.

@sdelamo sdelamo added the type: bug Something isn't working label Jun 5, 2023
@sdelamo
Copy link
Contributor Author

sdelamo commented Jun 5, 2023

@dstepanov TraceInterceptorSpec.test trace mono test fails. Can you investigate?

@n0tl3ss
Copy link
Member

n0tl3ss commented Jun 5, 2023

Hi @sdelamo, changing test code to makes test pass:

        @NewSpan("trace-mono")
        Publisher<String> mono(@SpanTag("more.stuff") String name) {
            return ReactivePropagation.propagate(
                    PropagatedContext.get(),
                    Mono.fromCallable({
                        spanCustomizer.tag("foo", "bar")
                        return name
                    }).subscribeOn(Schedulers.boundedElastic())
            )
        }

I guess the issue is with subscribeOn part because it happens on another thread.

@dstepanov
Copy link
Contributor

I will check

@sdelamo
Copy link
Contributor Author

sdelamo commented Aug 4, 2023

@dstepanov can you check this?

@dstepanov
Copy link
Contributor

This is not supported by default, but the propagation using Micrometer should work

@sdelamo sdelamo requested a review from timyates December 4, 2023 09:59
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo sdelamo merged commit 43efed0 into master Dec 4, 2023
12 checks passed
@sdelamo sdelamo deleted the revertpending branch December 4, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants