Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling exceptions caused by value serializers #37

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Handling exceptions caused by value serializers #37

merged 1 commit into from
Jun 4, 2020

Commits on May 10, 2020

  1. Handling exceptions caused by value serializers 

    If serialization and deserialization exceptions aren't handled, result CompletableFuture's will never be completed and cause hangs wherever they are accessed.

This fix wraps all serialization and deserialization in try-catch and completes the CompletableFuture's exceptionally after catching an exception.

This is only necessary for the async cache, the sync cache doesn't run into this problem and doesn't swallow such exceptions.
    @vemilyus
    vemilyus committed May 10, 2020
    Configuration menu
    Copy the full SHA
    5398ee5 View commit details
    Browse the repository at this point in the history