Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultSecurityService.hasRole(String roleName) should honor custom roles-name setting of token #211

Closed
mathwizard opened this issue Apr 7, 2020 · 1 comment
Closed

DefaultSecurityService.hasRole(String roleName) should honor custom roles-name setting of token #211

mathwizard opened this issue Apr 7, 2020 · 1 comment

Comments

@mathwizard
Copy link
Contributor

The DefaultSecurityService.hasRole(String roleName) currently by default searches the the "roles" attribute of token. This method should honor the custom settings set in property micronaut.security.service.token.roles-name

Steps to Reproduce

  1. Set custom roles-name property
  2. Attempt to call securityService.hasRole("roleName")

Expected Behaviour

The role should be found

Actual Behaviour

Role is not found
@mathwizard
Copy link
Contributor Author

#212

@sdelamo sdelamo closed this as completed in 6dc8040 Apr 7, 2020
sdelamo added a commit that referenced this issue Apr 7, 2020
@sdelamo
Merge pull request #213 from micronaut-projects/pullrequests/mathwiza…
e64ac70 
…rd/1.3.x

DefaultSecurityService.hasRole honor the custom roles-name key Fixes #211
sdelamo pushed a commit that referenced this issue Apr 21, 2020
@mathwizard @sdelamo
fix: SecurityService#hasRole honor roles-name
47a466e 
Fixes: #211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mathwizard