Add jakarta security annotation mapping #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
frehov
pushed a commit
to frehov/micronaut-security
that referenced
this pull request
Sep 13, 2021
… to NamedAnnotationMapper
…ir equivalent javax NamedAnnotationMapper
frehov
force-pushed
the
feature/add_jakarta_security_annotation_mapping
branch
from
822cf7d
to
6c987a4
Compare
|
Thanks code changes look good, we will need a test though. Probably just the same as https://github.com/micronaut-projects/micronaut-security/blob/master/security/src/test/groovy/io/micronaut/security/rolesallowed/RolesAllowedSpec.groovy with different annotations |
…cs and replace test controllers with jakarta annotated controllers
|
@graemerocher I've extended the original specs and replaced the controllers so that they use the jakarta annotation. |
sdelamo
requested changes
Sep 14, 2021
...notations/src/main/java/io/micronaut/security/annotation/JakartaDenyAllAnnotationMapper.java
Show resolved
Hide resolved
...tations/src/main/java/io/micronaut/security/annotation/JakartaPermitAllAnnotationMapper.java
Show resolved
Hide resolved
...ions/src/main/java/io/micronaut/security/annotation/JakartaRolesAllowedAnnotationMapper.java
Show resolved
Hide resolved
sdelamo
added this to In progress
in Micronaut Developers Work Coordination
via automation
sdelamo
moved this from In progress
to Review in progress
in Micronaut Developers Work Coordination
Micronaut Developers Work Coordination
automation
moved this from Review in progress
to Done
Sep 14, 2021
graemerocher
approved these changes
Sep 15, 2021
sdelamo
approved these changes
Sep 17, 2021
Micronaut Developers Work Coordination
automation
moved this from In progress
to Reviewer approved
Sep 17, 2021
Micronaut Developers Work Coordination
automation
moved this from Reviewer approved
to Done
Sep 17, 2021
|
@frehov Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched over the AnnotationMappers for javax security annotations to NamedAnnotationMapper as discussed in #774.
Added the Jakarta equaivalent mappers by extending the javax ones and overriding the namespace.
closes #774