fix: prevent ImportAnnotationVisitor walking non-visible classes #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ImportAnnotationVisitor would walk the spring hierarchy and cause package-private classes to have definitions created for them. This would then fail at runtime, as Micronaut could not access these defined beans. This fix only visits public classes to prevent this problem. Closes #521
graemerocher
approved these changes
Feb 12, 2024
|
sdelamo
approved these changes
Feb 12, 2024
dstepanov
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ImportAnnotationVisitor would walk the spring hierarchy and cause package-private classes to have definitions created for them.
This would then fail at runtime, as Micronaut could not access these defined beans.
This fix only visits public classes to prevent this problem.
Closes #521
Added @dstepanov and @graemerocher as reviewers as although this fixes the issue, I'm not 100% sure on my understanding of the mechanisms at play here