Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests of Maven configuration for unit tests with Spock or KotlinTest #347

Merged

Conversation

alejandropg
Copy link

Add tests to check the generated pom.xml when you are using Spock or KotlinTest.

@alvarosanchez I think this is what your was looking for. Tell me If you want that I change something.

@alvarosanchez alvarosanchez merged commit 18a1216 into micronaut-projects:master Jul 19, 2020
@alvarosanchez
Copy link
Member

Thanks!

@alejandropg alejandropg deleted the add-maven-surefire-tests branch July 19, 2020 08:11
@alejandropg
Copy link
Author

@alvarosanchez I think with this I finished my proposals for now. Any way if you want to suggest something to me, don't hesitate and contact me 👍
Thanks a lot, and really congrats! 👏👏👏👏

@graemerocher
Copy link
Contributor

Thanks for all the contributions, big improvements. Wish there was a way to move the annotation processor config to the parent, but couldn't work out myself how that was possible.

@alejandropg
Copy link
Author

@graemerocher the problem is that the parent is "static" so you can not change nor configure it depending of what are you using in your project.

Our approximation was to create two parent, one for Java and other for Kotlin. In this case you should configure all the possible annotation processors, even if in fact you are not using some of them. This should not be too much problematic because if the annotation is not in your code, the processor do nothing.

Here you can see our example of this:

@graemerocher
Copy link
Contributor

Yeah but I think that doesn't work if you need to customize the processors in the child

@alejandropg
Copy link
Author

Coooooorrect, the best example is if you want to use Lombok, where you need to ensure that their annotation processor is before of Micronaut.

Other way could be to modify the annotation processor plugin to be more flexible. But I don't know if it's worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants