Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add reactive clients #876

Closed
wants to merge 2 commits into from
Closed

feat: add reactive clients #876

wants to merge 2 commits into from

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Aug 13, 2021

@sdelamo sdelamo requested a review from ilopmar August 13, 2021 15:56
ilopmar
ilopmar suggested changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@ilopmar ilopmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss the tests that only add the xxxx-http-client features and check that only that dependency is added but not the micronaut-xxxx. I mean, adding just rxjava3-http-client feature and get the artifact micronaut-rxjava3-http-client.

@sdelamo
Copy link
Contributor Author

sdelamo commented Aug 16, 2021

RxJavaOne to RxJava1 RxJavaThree to RxJava3

I miss the tests that only add the xxxx-http-client features and check that only that dependency is added but not the micronaut-xxxx. I mean, adding just rxjava3-http-client feature and get the artifact micronaut-rxjava3-http-client.

You cannot add rxjava3-http-client because they are are not visible.

@sdelamo sdelamo requested a review from ilopmar August 16, 2021 09:19
@jameskleeh
Copy link
Contributor

I cherry picked this from 3.0.x

@jameskleeh jameskleeh closed this Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilopmar ilopmar ilopmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdelamo @jameskleeh @ilopmar