Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type pollution test harness #1048

Open
wants to merge 7 commits into
base: 4.4.x
Choose a base branch
from
Open

Add type pollution test harness #1048

wants to merge 7 commits into from

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Jun 19, 2024

Add a test harness that can be used to check for type pollution issues. Heavily inspired by and similar to https://github.com/RedHatPerf/type-pollution-agent . Key differences are:

  • Works with in-VM ByteBuddyAgent. This makes installation somewhat easier in tests
  • Fully programmatic API, to make threshold verification work without parsing summary reports. Also means this cannot be used for existing applications, it needs app code that explicitly listens to events
  • indy-based implementation instead of invokestatic
  • Less focus on performance, this is for testing only
  • No type check miss support

Add a test harness that can be used to check for type pollution issues. Heavily inspired by and similar to https://github.com/RedHatPerf/type-pollution-agent . Key differences are:

- Works with in-VM ByteBuddyAgent. This makes installation somewhat easier in tests
- Fully programmatic API, to make threshold verification work without parsing summary reports. Also means this cannot be used for existing applications, it needs app code that explicitly listens to events
- indy-based implementation instead of invokestatic
- Less focus on performance, this is for testing only
- No type check miss support
@yawkat yawkat added the type: enhancement New feature or request label Jun 19, 2024
@yawkat yawkat added this to the 4.4.0 milestone Jun 19, 2024
@yawkat
Copy link
Member Author

yawkat commented Jun 19, 2024

hmm, agent issues on CI...

Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants