Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2 #515

Merged
merged 4 commits into from
Apr 26, 2023
Merged

M2 #515

merged 4 commits into from
Apr 26, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Apr 24, 2023

No description provided.

@sdelamo sdelamo added the type: dependency-upgrade Upgrade a dependency label Apr 24, 2023
@sdelamo sdelamo assigned timyates and wetted and unassigned timyates Apr 25, 2023
@sdelamo
Copy link
Contributor Author

sdelamo commented Apr 25, 2023

@wetted can you investigate this PR failure and contribute for it to solve it?

@wetted wetted marked this pull request as ready for review April 25, 2023 14:40
@wetted
Copy link
Contributor

wetted commented Apr 25, 2023

@wetted can you investigate this PR failure and contribute for it to solve it?

@sdelamo this is good to go

Previously these wer in suppressions.xml, but then in a micronaut-build template update they were accidentally removed.

Our current setup allows for a custom-suppressions.xml file, so I added them back in there to avoid them getting removed again
@timyates
Copy link
Member

timyates commented Apr 26, 2023

Pushed a fix to add back the suppressions we used to have (a micronaut-template PR deleted them)

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo sdelamo merged commit ce4da04 into master Apr 26, 2023
4 checks passed
@sdelamo sdelamo deleted the sdelamo-patch-3 branch April 26, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants