Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add enctype to Form #676

Merged
merged 6 commits into from
Dec 18, 2023
Merged

feat: Add enctype to Form #676

merged 6 commits into from
Dec 18, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Dec 18, 2023

Close: #674

@sdelamo sdelamo added the type: improvement A minor improvement to an existing feature label Dec 18, 2023
timyates
timyates approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better :-)

I pushed a fix for form being null in the EnctypePostRequiredValidator

1126d21

Please make sure I chose the right path 😉

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
72.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sdelamo sdelamo merged commit 2e01053 into master Dec 18, 2023
25 checks passed
@sdelamo sdelamo deleted the issue-674 branch December 18, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timyates timyates timyates approved these changes

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
4.3.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support enctype in Form
2 participants
@sdelamo @timyates