HTMX Integration #735
Merged
HTMX Integration #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close: #660 - Defines constants for HTMX Request Header and HTMX Response Headers - Defines HTMXResponse for out of band swaps. - Defines HtmxRequestUtils Allows to bind a HttpRequestHeaders to a controller method.
timyates
requested changes
Mar 13, 2024
views-htmx/src/main/java/io/micronaut/views/htmx/HtmxConfigurationProperties.java
Outdated
Show resolved
Hide resolved
views-htmx/src/main/java/io/micronaut/views/htmx/HtmxConfigurationProperties.java
Outdated
Show resolved
Hide resolved
views-htmx/src/main/java/io/micronaut/views/htmx/HtmxConfigurationProperties.java
Outdated
Show resolved
Hide resolved
views-htmx/src/main/java/io/micronaut/views/htmx/HtmxConfigurationProperties.java
Outdated
Show resolved
Hide resolved
views-htmx/src/main/java/io/micronaut/views/htmx/HtmxConfigurationProperties.java
Outdated
Show resolved
Hide resolved
views-htmx/src/main/java/io/micronaut/views/htmx/http/HtmxRequestUtils.java
Outdated
Show resolved
Hide resolved
views-htmx/src/test/java/io/micronaut/views/htmx/HtmxConfigurationTest.java
Show resolved
Hide resolved
...test/java/io/micronaut/views/htmx/http/HtmxRequestHeadersTypedRequestArgumentBinderTest.java
Outdated
Show resolved
Hide resolved
views-htmx/src/test/java/io/micronaut/views/htmx/http/TodoItemMapper.java
Outdated
Show resolved
Hide resolved
…tionProperties.java Co-authored-by: Tim Yates <tim.yates@gmail.com>
…tionProperties.java Co-authored-by: Tim Yates <tim.yates@gmail.com>
…tionProperties.java Co-authored-by: Tim Yates <tim.yates@gmail.com>
…tionProperties.java Co-authored-by: Tim Yates <tim.yates@gmail.com>
…tionProperties.java Co-authored-by: Tim Yates <tim.yates@gmail.com>
…tionTest.java Co-authored-by: Tim Yates <tim.yates@gmail.com>
…estHeadersTypedRequestArgumentBinderTest.java Co-authored-by: Tim Yates <tim.yates@gmail.com>
…Mapper.java Co-authored-by: Tim Yates <tim.yates@gmail.com>
…estUtils.java Co-authored-by: Tim Yates <tim.yates@gmail.com>
…tionTest.java Co-authored-by: Tim Yates <tim.yates@gmail.com>
…tionTest.java Co-authored-by: Tim Yates <tim.yates@gmail.com>
| * @param <T> The model type | ||
| */ | ||
| @Experimental | ||
| public final class HtmxResponse<T> { |
There was a problem hiding this comment.
is the plan to enable more builder methods to set common HTMX response headers?
There was a problem hiding this comment.
I thought about that. However, I am not sure if it is necessary since you can do:
HttpResponse.ok(HttpResponse.builder()
.modelAndView()
.modelAndView()
.build())
.header(HtmxResponseHeaders.HX_REFRESH, StringUtils.TRUE);
timyates
approved these changes
Mar 14, 2024
|
@sdelamo This should target the 5.2.x branch if it's for 4.4.0? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #660
Allows to bind a HttpRequestHeaders to a controller method.