Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicroProfile JWT RBAC 2.0 Specification Review #105

Closed
23 tasks done
sberyozkin opened this issue Nov 3, 2021 · 2 comments
Closed
23 tasks done

MicroProfile JWT RBAC 2.0 Specification Review #105

sberyozkin opened this issue Nov 3, 2021 · 2 comments
Labels
pmc-approved EF PMC has approved the lifecycle issue Release Review wg-approved MP WG has approved the lifecycle issue

Comments

@sberyozkin
Copy link
Contributor

sberyozkin commented Nov 3, 2021

  • Specification name and version
  • Add the label Release Review
  • Naming conventions for artifacts:
    • Specification PDF in the form of microprofile-project-spec-version.pdf
    • Specification HTML in the form of microprofile-project-spec-version.html
    • project is the microprofile specification short project name (config, health, ...)
    • version is the two digit x.y version of the specification

  • The Nexus Staging links (orgeclipsemicroprofile-NNNN where NNNN is the staging repository id) (eg, https://oss.sonatype.org/content/repositories/orgeclipsemicroprofile-NNNN/org/eclipse/microprofile/config/) which contain all the binaries and relevant documentation:

@radcortez radcortez changed the title MP JWT RBAC 2.0 Specification Review MicroProfile JWT RBAC 2.0 Specification Review Nov 9, 2021
@kwsutter
Copy link
Member

A couple of comments...

  • Same issue as the Config specification with the copyright in the EFSL (in the Spec documents) still stating 2020 (instead of 2021).
    Copyright (c) 2016, 2020 Eclipse Foundation.
  • I added a couple of comments to the CCR and TCK Results.
  • There is no license in the API jar file. This might be critical enough to force a respin...
  • Again, I found the extra TCK license in the javadoc jar file. No idea why that license would be necessary, but it should be cleaned up. Not a requirement for this ballot, but if you have to clean up the API jar file...

I'd like to know if the API jar file needs to be recreated before I vote... Thanks!

@radcortez
Copy link

  • Same issue as the Config specification with the copyright in the EFSL (in the Spec documents) still stating 2020 (instead of 2021).
    Copyright (c) 2016, 2020 Eclipse Foundation.

Fixed

  • There is no license in the API jar file. This might be critical enough to force a respin...

Fixed

  • Again, I found the extra TCK license in the javadoc jar file. No idea why that license would be necessary, but it should be cleaned up. Not a requirement for this ballot, but if you have to clean up the API jar file...

Fixed

@radcortez radcortez added ballot Release Review, Plan Review, Progress Review issue is now in ballot and should not be updated wg-approved MP WG has approved the lifecycle issue pmc-approved EF PMC has approved the lifecycle issue and removed ballot Release Review, Plan Review, Progress Review issue is now in ballot and should not be updated labels Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pmc-approved EF PMC has approved the lifecycle issue Release Review wg-approved MP WG has approved the lifecycle issue
Projects
None yet
Development

No branches or pull requests

3 participants