This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
ports/esp32/machine_hw_spi: Fix for issue #225 #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
reviewed
Dec 14, 2017
ports/esp32/machine_hw_spi.c
Outdated
|
|
||
| // doesn't need ceil(); loop ends when bits_remaining is 0 | ||
| offset += transaction.length / 8; | ||
| } | ||
| } | ||
|
|
||
| spi_device_transmit(self->spi, &transaction); |
There was a problem hiding this comment.
I think this line should also be removed, else it will send dummy data at the end.
There was a problem hiding this comment.
Agreed, fixed, squashed, pushed.
#225 Breaks up transfers to a max of 32736 bits (4092 bytes).
|
Thanks! Merged upstream in 9123c8d9460017b8c8dc4a38d9a26968eacaa4cb |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#225
Breaks up transfers to a max of 32736 bits (4092 bytes).