Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org Chart in Persona Card showing disabled users #2507

Closed
sympmarc opened this issue Nov 2, 2022 · 14 comments
Closed

Org Chart in Persona Card showing disabled users #2507

sympmarc opened this issue Nov 2, 2022 · 14 comments

Comments

@sympmarc
Copy link
Contributor

sympmarc commented Nov 2, 2022

Version used
Ex: 4.6.1

Describe the bug
When displaying people using the People layout, we can choose to show the persona card on hover. I think there's a bug in that implementation, in that people who are disabled in AAD are showing up. This doesn't match the behavior of the Org Charts in Microsoft Search results.

To Reproduce
Steps to reproduce the behavior:

To reproduce, you need to have user profiles with Manager values. Those user profiles must be disabled in AAD. If you search for the Manager in Microsoft Search and look at the Org Chart, you won't see the disabled user(s). If you search in the PnP Modern Search Web Parts and look at the Org Chart in the persona card, you will.

Expected behavior
Consistency between the two Org Chart implementations

Screenshots
NA

Desktop (please complete the following information):

  • Browser Edge

Additional context
We've tested this pretty thoroughly and believe it to be a bug.

@wobba
Copy link
Collaborator

wobba commented Nov 2, 2022

I assume this is the mgt card? And if so their repo is https://github.com/microsoftgraph/microsoft-graph-toolkit/issues and you can close this issue 🙂

@sympmarc
Copy link
Contributor Author

sympmarc commented Nov 2, 2022

Not sure, as I'm just using this setting on the 2 of 4 property panel for the PnP Search Results Web Part. Wouldn't it be how the persona card is used in that implementation?

image

@wobba
Copy link
Collaborator

wobba commented Nov 2, 2022

Correct, and we reuse the graph toolkit components and have no control over their API calls or logic. We just load the card with a UPN and things happen.

@sympmarc
Copy link
Contributor Author

sympmarc commented Nov 2, 2022

Ok, got it. I'll lodge a complaint over there.

@sympmarc
Copy link
Contributor Author

sympmarc commented Nov 2, 2022

Issue in MGT

@sympmarc
Copy link
Contributor Author

sympmarc commented Dec 5, 2022

The MGT team is putting a fix into the December release.

@wobba
Copy link
Collaborator

wobba commented Dec 5, 2022

Appreciate the update.

wobba added a commit that referenced this issue Jan 3, 2023
wobba added a commit that referenced this issue Jan 3, 2023
@wobba
Copy link
Collaborator

wobba commented Jan 3, 2023

Packages are now updated in the dev branch

@sympmarc
Copy link
Contributor Author

sympmarc commented Jan 3, 2023

Just out of curiosity, do you have a timeframe for the next release? I won't hold you to it. :)

@wobba
Copy link
Collaborator

wobba commented Jan 3, 2023

Sometime in 2023 😁

@Ami99049
Copy link

Ami99049 commented Aug 30, 2023

@wobba @sympmarc @stevebeauge Have you released the new version with the changes in Hover Card org Chart or is it still in development phase

@kasperbolarsen
Copy link
Collaborator

Please review this issue, as it will inform you that the Org Chart is a MGT component, and just used by this project.

@Ami99049
Copy link

@kasperbolarsen I installed pnp version 4.8 and still Disabled users is visible in Hover Card Org Chart via Microsoft Search as Data source. Is there any way to exclude those users.

@kasperbolarsen
Copy link
Collaborator

Not in this project as we are just using the MGT component.
You should log the issue with MGT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants