-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filters rendering #2624
Comments
Can you verify that data is coming back for your repro steps for the Level 3 one? |
F12 dev tools and network tab. Examine the network response when the search query comes back with JSON data. And compare the request with what is done with the refresh query. |
Compared as advised. In both cases - pre- and after refreshin I am getting lines of errors as follows: "- Uncaught (in promise) TypeError: Cannot set properties to null
The different, additional line I get after doing a refresh reads: "Some icons were reregistered. Applications should only call registerIcons modern-search-result.... for any given icon once" |
Not console...look at the json response from the search call in the network tab. |
@wobba Does the above make sense? Anything else you would like me to provide? What are the steps in investigating this? |
Having someone who understand looking at network traces per click verify request and response following your steps :) You screenshots don't really help much in terms of understanding so repro is likely needed when someone has the time. |
microsoft-search#2624: Bug fix to show current ui filters without page refresh
#2624: Bug fix to unhide disappearing filters without page refresh
Fixed in the dev branch. Thank you @salimbharuchi |
…e filter web part This bug happened due to the regression of microsoft-search#2624
Version used
Version 4.8
Describe the bug
Upon selection of values, associated with the first two filters, it hides the rest of the filters. The filters reappear if the browser page is refreshed. The filters are 5 in total and correspond to columns with the same names as created in the document libraries.
To Reproduce
Detailed steps to reproduce the behavior:
Expected behavior
The filters should not hide if there are values associated with files within that particular filter. Constant refreshing of the browser page to prompt the filters to re-appear is not acceptable from user perspective. It used to be the filters were working properly and the fault seems to have started occuring after the upload of some files on the site. The upload may just be a coincidence and may not have anything to do with the issue.
Screenshots
Screenshot 1
Screenshot 2
Screenshot 3
Screenshot 4
Screenshot 5
Desktop (please complete the following information):
Additional context
The problem started manifesting itself after latest uploads of some few hundred files into some of the document libraries. Up until that moment the filters were working correctly. The SP site contains about 17 000 items in total. Even if the "Query template" box in the 'Search Results' webpart is configured to perform the search in only one of the libraries, one that only has about 3000 items, that does not change the behaviour of the filters. The site has been re-indexed and the separate document libraries too. New page with the same webparts with setting up the options in the filters section from new has been created, however the problem still persists.
The filters correspond to columns, created at a site level, and the files within the document libraries are tagged with different labels. The crawled properties (site columns called Level1 through to Level5) have been mapped to RefinableString properties on SP Admin Center. The filters stopped working correctly regarding both - the initially uploaded files and tags applied and also the recently uploaded files. On a separate note, the whole PNP module appears to be sluggish and barely responsive. Hard reset with clearing the cache of the browser has been done and switch to a different browser attempted as well.
The text was updated successfully, but these errors were encountered: