Fix for Select All button in DetailsList #2678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with how the SelectionZone in the search results container is implemented together with the DetailsList internal selection handling. Clicking Select All in the DetailsList selects all items in the list but does not update selectedKeys in the templateContext.
This is also the issue behind #2289 so that should also be fixed after this.
This fix adds the
data-selection-all-toggle=true
property to the div element containing the Select All button which makes the search results container SelectionZone also trigger on the button click.