Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nb-no.js #2881

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Update nb-no.js #2881

merged 2 commits into from
Mar 30, 2023

Conversation

kjetilodegaarden
Copy link
Contributor

The norwegian translation of default search option is wrong. Changed it to "Default" instead of "Misligholde" which makes no sense with regards to sorting.

The norwegian translation of default search option is wrong. Changed it to "Default" instead of "Misligholde" which makes no sense with regards to sorting.
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@wobba wobba changed the base branch from main to develop March 29, 2023 15:16
@wobba
Copy link
Collaborator

wobba commented Mar 29, 2023

"Default" is English. I would rather have "Standard" which aligns with the Danish and Swedish translations.

changed to standard, norwegian customer wanted default. But agreed. Standard is better.
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

@kjetilodegaarden
Copy link
Contributor Author

Agreed. Norwegian customer wanted default so did not think about it. Standard is better.

@wobba wobba merged commit 900e77c into microsoft-search:develop Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants