Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added collapse specification property #3043

Merged
merged 4 commits into from
Jun 4, 2023

Conversation

svenbru
Copy link
Contributor

@svenbru svenbru commented May 30, 2023

Added the ability to configure the collapse specification property in the SharePoint data source, like mentioned in older issues like #2135 and #911

CollapseSpecification

@wobba
Copy link
Collaborator

wobba commented May 30, 2023

Care to add it for the Graph provider as well? It's on the beta endpoint named collapseProperties.

https://learn.microsoft.com/en-us/graph/api/resources/searchrequest?view=graph-rest-beta

@svenbru
Copy link
Contributor Author

svenbru commented May 31, 2023

@wobba Sure! I made the changes for the Graph provider.

@wobba
Copy link
Collaborator

wobba commented May 31, 2023

There are some merge conflicts on loc files to resolve.

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
57.4% 57.4% Duplication

@svenbru
Copy link
Contributor Author

svenbru commented Jun 1, 2023

Probably had to do with some auto formatting in VS Code, The conflicts should be corrected now.

@wobba wobba merged commit 52d0d90 into microsoft-search:develop Jun 4, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants