Allows to specify the result source by name #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @luismanez and a good one :) |
|
Thanks @luismanez that was quick ;). I'll review this when have time this week. Thanks again. |
|
@luismanez Can you resolve merge conflicts due me adding a fix for the dynamic data issue. |
|
should be fine now @wobba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to configure the Search Results webpart setting the Result source by name, using the format: Source level|Source Name (idea taken from the Search Query tool from @wobba).
@FranckyC / @wobba would be good if someone in the team can review the ResultSourceIdDescription translations to French and Dutch :)