Include WebPartTitle for SearchBox WebPart #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have configured PGP to ensure the code commit is verified |
|
This is the end result - with the ability to have a webpart title - rather than a separate TEXT block (and big space/gap)
|
|
|
** How do I sign/verify the 'prior' commits ?? |
wobba
reviewed
Jan 11, 2024
| let renderTitle: JSX.Element = null; | ||
|
|
||
| // WebPart title | ||
| renderTitle = <WebPartTitle |
There was a problem hiding this comment.
If a property is not filled out, will this render with no pixels taken?
There was a problem hiding this comment.
Correct. I've checked the output/html - and no title has zero impact to the rendered content. No additional pixels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure consistency for the SearchResults, Filter and Verticals - I've included a TITLE for the WebPart for SearchBox.
This is especially useful on a HOME PAGE - when needing to 'send query to new page'.