Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to mgt4 #3556

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Conversation

patrikhellgren
Copy link
Contributor

Upgrades MGT to version 4. This resolves the issue reported in #3505.
This also introduces two new settings for MGT disambiguation to make it possible to run different versions of MGT on the same page without the use of mgt-spfx that has been deprecated in MGT 4. One setting is for the general Use Microsoft Graph Toolkit setting and the other is for the Show Persona hover card setting since there seems to be no way to get to the main webpart properties from the layouts.

Unfortunately there has been some changes to the mgt components property naming and styling that will require changes in already existing custom layouts/columns. E.g. for mgt-person the oneLine property has changed casing to oneline and the font styling has also changed. The default Person layout should work when using no disambiguation since it uses mgt-person.

Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wobba wobba merged commit cda93b7 into microsoft-search:develop Feb 26, 2024
1 check passed
@wobba
Copy link
Collaborator

wobba commented Feb 26, 2024

Thank you and awesome work! Hopefully all toolkit issues should be gone :)

@patrikhellgren patrikhellgren deleted the upgrade-to-mgt4 branch February 26, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants