Fast-serve update to match the most recent changes. #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also found, that condition |
|
wobba
reviewed
Feb 28, 2024
| @@ -94,7 +87,7 @@ const envCheck = build.subTask('environmentCheck', (gulp, config, done) => { | |||
| }, { | |||
| // Skip HoverReactionsBar from spfx controls as it's not used and is bundles | |||
| test: /index\.js$/, | |||
| include: [/spfx-controls-react\/lib\/controls\/HoverReactionsBar/], | |||
| include: [/spfx-controls-react[/\\]lib[/\\]controls[/\\]HoverReactionsBar/], | |||
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that you already use the latest (1.18.10) fast-serve version for SPFx 1.18 (hooray!).
This PR simply adds some small updates regarding the usage of the latest fast-serve and other minor fixes:
fast-serve/config.json- not needed anymore, default config settings are usedservecommand was simplified for easier updates in the futuregulpfile.js-build.tslintCmd.enabled = false;is not needed anymore, since tslint is not used in SPFxfast-serve/webpack.extend.jsnow fully matches the corresponding "configureWebpack" changes from gulpfile.jsconfig/serve.jsonthe "api" property is not used anymore in SPFx 1.18, but produces some errors for OOB "gulp serve", thus was removed