Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[demo] Use toasts more #54

Closed
juharris opened this issue Nov 29, 2019 · 0 comments · Fixed by #72
Closed

[demo] Use toasts more #54

juharris opened this issue Nov 29, 2019 · 0 comments · Fixed by #72
Labels
demo Relates to the code to demonstrate the framework enhancement New feature or request good first issue Good for newcomers

Comments

@juharris
Copy link
Member

There are plenty of toasts when adding a new model but for other pages just console logging or alerts are used. There are lots of TODOs on those pages for when toasts should be used.
@juharris juharris added enhancement New feature or request good first issue Good for newcomers demo Relates to the code to demonstrate the framework labels Nov 29, 2019
juharris pushed a commit that referenced this issue Dec 19, 2019
demo: Toast more.
ca6b57b 
Resolves #54
@juharris juharris mentioned this issue Dec 19, 2019
Merged
juharris added a commit that referenced this issue Dec 19, 2019
@juharris
demo: Toast more. (#72)
6f7a69d 
Resolves #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
demo Relates to the code to demonstrate the framework enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[demo] Use toasts more microsoft/0xDeCA10B
1 participant
@juharris