Skip to content

Commit

Permalink
🐛 fixes opening of url in browser
Browse files Browse the repository at this point in the history 
fixes #77

See also dotnet/runtime#28005 (comment)
  • Loading branch information
@FH-Inway
FH-Inway committed Aug 12, 2023
1 parent d508ea0 commit 0984185
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 20 deletions.
40 changes: 20 additions & 20 deletions 2LCS/Forms/MainForm.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ public static CookieContainer GetUriCookieContainer()

private void AssetLibraryToolStripMenuItem_Click(object sender, EventArgs e)
{
Process.Start($"{URIHandler.LCS_URL}/V2/AssetLibrary/{_selectedProject.Id}");
WebBrowserHelper.OpenUri($"{URIHandler.LCS_URL}/V2/AssetLibrary/{_selectedProject.Id}");
}

private async void ChangeProjectMenuItem_Click(object sender, EventArgs e)
Expand Down Expand Up @@ -551,7 +551,7 @@ private void CustomLinkClicked(object sender, EventArgs e)
{
var item = (CloudHostedInstance)row.DataBoundItem;
var link = ParseCustomLink(((ToolStripMenuItem)sender).ToolTipText, item);
Process.Start(link);
WebBrowserHelper.OpenUri(link);
}
Cursor = Cursors.Default;
}
Expand Down Expand Up @@ -580,7 +580,7 @@ private void DataPackagesHistoryToolStripMenuItem_Click(object sender, EventArgs
foreach (DataGridViewRow row in SelectedDataGridView.SelectedRows)
{
var item = (CloudHostedInstance)row.DataBoundItem;
Process.Start($"{URIHandler.LCS_URL}/V2/ConfigurationAndDataManagementHistory/{_selectedProject.Id}?environmentId={item.EnvironmentId}");
WebBrowserHelper.OpenUri($"{URIHandler.LCS_URL}/V2/ConfigurationAndDataManagementHistory/{_selectedProject.Id}?environmentId={item.EnvironmentId}");
}
Cursor = Cursors.Default;
}
Expand Down Expand Up @@ -694,7 +694,7 @@ private void DetailedVersionInformationToolStripMenuItem_Click(object sender, Ev
foreach (DataGridViewRow row in SelectedDataGridView.SelectedRows)
{
var item = (CloudHostedInstance)row.DataBoundItem;
Process.Start($"{URIHandler.LCS_DIAG_URL}/BuildInfo/Index/{_selectedProject.Id}?lcsEnvironmentId={item.EnvironmentId}");
WebBrowserHelper.OpenUri($"{URIHandler.LCS_DIAG_URL}/BuildInfo/Index/{_selectedProject.Id}?lcsEnvironmentId={item.EnvironmentId}");
}
Cursor = Cursors.Default;
}
Expand All @@ -705,7 +705,7 @@ private void EnvironmentChangeHistoryToolStripMenuItem_Click(object sender, Even
foreach (DataGridViewRow row in SelectedDataGridView.SelectedRows)
{
var item = (CloudHostedInstance)row.DataBoundItem;
Process.Start($"{URIHandler.LCS_URL}/V2/EnvironmentHistory/{_selectedProject.Id}?LcsEnvironmentName={item.DisplayName}&EnvironmentId={item.EnvironmentId}&EnvironmentType={item.SaasEnvironmentType}");
WebBrowserHelper.OpenUri($"{URIHandler.LCS_URL}/V2/EnvironmentHistory/{_selectedProject.Id}?LcsEnvironmentName={item.DisplayName}&EnvironmentId={item.EnvironmentId}&EnvironmentType={item.SaasEnvironmentType}");
}
Cursor = Cursors.Default;
}
Expand All @@ -716,7 +716,7 @@ private void EnvironmentMonitoringToolStripMenuItem_Click(object sender, EventAr
foreach (DataGridViewRow row in SelectedDataGridView.SelectedRows)
{
var item = (CloudHostedInstance)row.DataBoundItem;
Process.Start($"{URIHandler.LCS_DIAG_URL}/Monitoring/Index/{_selectedProject.Id}?environmentId={item.EnvironmentId}");
WebBrowserHelper.OpenUri($"{URIHandler.LCS_DIAG_URL}/Monitoring/Index/{_selectedProject.Id}?environmentId={item.EnvironmentId}");
}
Cursor = Cursors.Default;
}
Expand Down Expand Up @@ -1482,7 +1482,7 @@ private void InstanceDetailsToolStripMenuItem_Click(object sender, EventArgs e)
foreach (DataGridViewRow row in SelectedDataGridView.SelectedRows)
{
var item = (CloudHostedInstance)row.DataBoundItem;
Process.Start(_httpClientHelper.GetEnvironmentDetailsUrl(item));
WebBrowserHelper.OpenUri(_httpClientHelper.GetEnvironmentDetailsUrl(item));
}
Cursor = Cursors.Default;
}
Expand Down Expand Up @@ -1530,7 +1530,7 @@ private void LogonToApplicationToolStripMenuItem_Click(object sender, EventArgs
{
if (link.DisplayName == "Log on to environment")
{
Process.Start(link.NavigationUri);
WebBrowserHelper.OpenUri(link.NavigationUri);
break;
}
}
Expand Down Expand Up @@ -1726,7 +1726,7 @@ private void OpenRDPConnectionToolStripMenuItem_Click(object sender, EventArgs e

private void OpenWorkItemsToolStripMenuItem_Click(object sender, EventArgs e)
{
Process.Start($"https://lcs.dynamics.com/V2/WorkItemsManagement/{_selectedProject.Id}");
WebBrowserHelper.OpenUri($"https://lcs.dynamics.com/V2/WorkItemsManagement/{_selectedProject.Id}");
}

private void ParametersToolStripMenuItem_Click(object sender, EventArgs e)
Expand Down Expand Up @@ -1759,17 +1759,17 @@ private string ParseCustomLink(string template, CloudHostedInstance instance)
private void ProjectLinkClicked(object sender, EventArgs e)
{
var link = ((ToolStripMenuItem)sender).ToolTipText;
Process.Start(link);
WebBrowserHelper.OpenUri(link);
}

private void ProjectSettingsToolStripMenuItem_Click(object sender, EventArgs e)
{
Process.Start($"https://lcs.dynamics.com/V2/ProjectSettings/{_selectedProject.Id}");
WebBrowserHelper.OpenUri($"https://lcs.dynamics.com/V2/ProjectSettings/{_selectedProject.Id}");
}

private void ProjectUsersToolStripMenuItem_Click(object sender, EventArgs e)
{
Process.Start($"https://lcs.dynamics.com/V2/ProjectUserManagement/{_selectedProject.Id}");
WebBrowserHelper.OpenUri($"https://lcs.dynamics.com/V2/ProjectUserManagement/{_selectedProject.Id}");
}

private async Task RefreshChe(bool reloadFromLcs = true)
Expand Down Expand Up @@ -2153,7 +2153,7 @@ private void SaasShowPasswordsPowershellMenuItem_Click(object sender, EventArgs

private void ServiceRequestsToolStripMenuItem_Click(object sender, EventArgs e)
{
Process.Start($"https://lcs.dynamics.com/V2/WorkItemsManagement/{_selectedProject.Id}?ActiveVerticalPivot=3");
WebBrowserHelper.OpenUri($"https://lcs.dynamics.com/V2/WorkItemsManagement/{_selectedProject.Id}?ActiveVerticalPivot=3");
}

private void SetInitialGridSettings()
Expand Down Expand Up @@ -2241,22 +2241,22 @@ private void StopInstanceMenuItem_Click(object sender, EventArgs e)

private void SubscriptionEstimatorToolStripMenuItem_Click(object sender, EventArgs e)
{
Process.Start($"https://sizing.lcs.dynamics.com/SubscriptionEstimator/Estimate/{_selectedProject.Id}");
WebBrowserHelper.OpenUri($"https://sizing.lcs.dynamics.com/SubscriptionEstimator/Estimate/{_selectedProject.Id}");
}

private void SubscriptionsAvailableToolStripMenuItem_Click(object sender, EventArgs e)
{
Process.Start($"https://lcs.dynamics.com/V2/OrganizationOfferDetail/{_selectedProject.Id}");
WebBrowserHelper.OpenUri($"https://lcs.dynamics.com/V2/OrganizationOfferDetail/{_selectedProject.Id}");
}

private void SupportIssuesToolStripMenuItem_Click(object sender, EventArgs e)
{
Process.Start($"https://lcs.dynamics.com/V2/WorkItemsManagement/{_selectedProject.Id}?ActiveVerticalPivot=2");
WebBrowserHelper.OpenUri($"https://lcs.dynamics.com/V2/WorkItemsManagement/{_selectedProject.Id}?ActiveVerticalPivot=2");
}

private void SystemDiagnosticsToolStripMenuItem_Click(object sender, EventArgs e)
{
Process.Start($"https://diag.lcs.dynamics.com/Home/Index/{_selectedProject.Id}");
WebBrowserHelper.OpenUri($"https://diag.lcs.dynamics.com/Home/Index/{_selectedProject.Id}");
}

private void LogonToPointOfSaleToolStripMenuItem_Click(object sender, EventArgs e)
Expand All @@ -2269,7 +2269,7 @@ private void LogonToPointOfSaleToolStripMenuItem_Click(object sender, EventArgs
{
if (link.DisplayName == "Log on to Cloud Point of Sale")
{
Process.Start(link.NavigationUri);
WebBrowserHelper.OpenUri(link.NavigationUri);
break;
}
}
Expand All @@ -2287,7 +2287,7 @@ private void LaunchDynamicsRetailStorefrontToolStripMenuItem_Click(object sender
{
if (link.DisplayName == "Launch Dynamics Retail Storefront")
{
Process.Start(link.NavigationUri);
WebBrowserHelper.OpenUri(link.NavigationUri);
break;
}
}
Expand All @@ -2305,7 +2305,7 @@ private void RetailServerURLToolStripMenuItem_Click(object sender, EventArgs e)
{
if (link.DisplayName == "Retail Server URL")
{
Process.Start(link.NavigationUri);
WebBrowserHelper.OpenUri(link.NavigationUri);
break;
}
}
Expand Down
18 changes: 18 additions & 0 deletions 2LCS/WebBrowserHelper.cs
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
//Use latest version of Internet Explorer in the webbrowser control
//https://stackoverflow.com/questions/17922308/use-latest-version-of-internet-explorer-in-the-webbrowser-control
using System;
using System.Diagnostics;

namespace LCS
{
Expand Down Expand Up @@ -81,5 +82,22 @@ private static int GetBrowserVersion()

return maxVer;
} // End Function GetBrowserVersion

/// <summary>
/// Opens a web page.
/// </summary>
/// <param name="uri">Url of web page.</param>
/// <remarks>
/// See https://github.com/microsoft/2LCS/issues/77
/// </remarks>
public static void OpenUri(string uri)
{
var processStartInfo = new ProcessStartInfo
{
FileName = uri,
UseShellExecute = true
};
Process.Start(processStartInfo);
}
}
}

0 comments on commit 0984185

Please sign in to comment.