Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Issue for Multi-Root project #228

Closed
gntpet opened this issue Oct 7, 2022 · 4 comments
Closed

Deployment Issue for Multi-Root project #228

gntpet opened this issue Oct 7, 2022 · 4 comments
Labels
bug Something isn't working Fix Ready Fix Ready Shipped Feature is included in the latest version

Comments

@gntpet
Copy link

gntpet commented Oct 7, 2022

Hey @freddydk,

I have these projects/apps stored in multi-root repository

project SRS.Core, whic has 4 apps

  • SRS.Core
  • email-queue
  • dynamic-layout
  • import-salary-journal

project SRS.it, which has single app

  • SRS.it

project SRS.no, which has single app

  • SRS.no

Here is the depdency graph between these apps:
image

if I specify SRS.it in PROJECTS secret, deployment code nicely finds dependencies and publishes 4 apps: SRS.it, SRS.core, email-queue, dynamic-layout apps

But, I also want to deploy app import-salary-journal, so i change my secret to : SRS.it, SRS.core (since i must specify 'projects' here)

Now, deployment codes sees duplicate apps and fails with an error
image

Is it a bug, or is this limitation on purpose?
What was the reason behind using 'PROJECTS' secret, instead of 'APPS' secret? Now, I specify list of projects to deploy, instead of list of APPS to deploy. Wonder what is the idea behind? I find it a bit limited, since I'm forced to deploy all apps from the project.

Best Regards,
Gintautas

@freddydk
Copy link
Contributor

freddydk commented Oct 7, 2022

Sounds like a bug
Any chance you could allow me access to the repo to have something to test on?
I would create a private fork and remove once done.

Note that you can provide projects in settings also (if you don't want to use secrets).
I will also consider adding support for project/app or simply app in project description.

@gntpet
Copy link
Author

gntpet commented Oct 10, 2022

I will contact you through Yammer

@freddydk freddydk added the bug Something isn't working label Oct 16, 2022
@freddydk
Copy link
Contributor

Got it, will try to repro

freddydk added a commit to microsoft/navcontainerhelper that referenced this issue Oct 16, 2022
@freddydk
Copy link
Contributor

freddydk commented Oct 16, 2022

I have fixed the first issue in BcContainerHelper - and it should be in preview in approx. 1 hour.
I have added the request of using project/app to the backlog as a request, but the original idea is that projects should be shippable units, meaning that you would have apps together with dependent apps in one project (or in one repo if using single project repos).
Hence the artifacts - you always get all apps from a project in one .zip file together.
You can add a setting to .github\AL-Go-Settings.json called BcContainerHelper and specify the value "preview", then you will use the preview.
You can also upgrade to the preview of AL-Go, which automatically uses BcContainerHelper preview.

@freddydk freddydk added Fix Ready Fix Ready Ships in a future version In Preview Currently available in AL-Go for GitHub preview and removed Ships in a future version labels Oct 16, 2022
@freddydk freddydk added Shipped Feature is included in the latest version and removed In Preview Currently available in AL-Go for GitHub preview labels Nov 2, 2022
@freddydk freddydk closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fix Ready Fix Ready Shipped Feature is included in the latest version
Projects
None yet
Development

No branches or pull requests

2 participants