Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create release action - CreateReleaseBranch error #391

Closed
kennetlindberg opened this issue Feb 10, 2023 · 9 comments · Fixed by #417
Closed

Create release action - CreateReleaseBranch error #391

kennetlindberg opened this issue Feb 10, 2023 · 9 comments · Fixed by #417
Labels
bug Something isn't working Fix Ready Fix Ready Shipped Feature is included in the latest version

Comments

@kennetlindberg
Copy link

When I tried to create a release, I got the following error in the "Create Release Branch" job

image
@freddydk
Copy link
Collaborator

What version of AL-Go is this?
(In the initialize step you can see the version number)

@kennetlindberg
Copy link
Author

I have my own fork of AL-Go, and it was updated 2 days ago, so it is quite recent. Sorry for the stupid question, but where do I find the version?

@freddydk
Copy link
Collaborator

freddydk commented Feb 12, 2023 •
edited

In the initialize step, you can see the version number (after running most workflows)

@freddydk
Copy link
Collaborator

you can also paste the url to your own fork here.

@kennetlindberg
Copy link
Author

https://github.com/kennetlindberg/AL-Go

@freddydk
Copy link
Collaborator

Would it be possible to add me to the repo on which this happens - this might be a bug, which I would like to investigate

@freddydk freddydk added the Under Investigation Issue is under investigation label Feb 21, 2023
@kennetlindberg
Copy link
Author

I've sent you an invite.

@freddydk
Copy link
Collaborator

freddydk commented Feb 23, 2023 •
edited

It is actually the CreateReleaseJob (CreateReleaseNotes) step which fails:
image
But without erroring out - and then not setting the release branch name - causing another error down the road.

Will investigate more - assuming that this is a bug in AL-Go

@freddydk freddydk added the bug Something isn't working label Feb 23, 2023
@freddydk freddydk linked a pull request Feb 23, 2023 that will close this issue
Issue #391 Create release action - CreateReleaseBranch error #417
Merged
@freddydk freddydk removed the Under Investigation Issue is under investigation label Feb 23, 2023
freddydk added a commit that referenced this issue Feb 24, 2023
@freddydk
Merge pull request #417 from freddydk/main
a9a340c 
Issue #391 Create release action - CreateReleaseBranch error
@mazhelez mazhelez mentioned this issue Feb 24, 2023
Merged
mazhelez added a commit to microsoft/ALAppExtensions that referenced this issue Feb 24, 2023
@mazhelez
Updated AL-Go System Files (#22253)
845a824 
## Preview

Note that when using the preview version of AL-Go for GitHub, you need
to Update your AL-Go system files, as soon as possible when told to do
so.

### Issues
- Issue [#391](microsoft/AL-Go#391) Create
release action - CreateReleaseBranch error

### Changes to Pull Request Process
In v2.4 and earlier, the PullRequestHandler would trigger the CI/CD
workflow to run the PR build.
Now, the PullRequestHandler will perform the build and the CI/CD
workflow is only run on push (or manual dispatch)

Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
@mazhelez mazhelez mentioned this issue Feb 26, 2023
Merged
aholstrup1 added a commit to microsoft/ALAppExtensions that referenced this issue Feb 26, 2023
@mazhelez @aholstrup1
Updated AL-Go System Files (#22263)
9227e99 
## Preview

Note that when using the preview version of AL-Go for GitHub, you need
to Update your AL-Go system files, as soon as possible when told to do
so.

### Issues
- Issue [#391](microsoft/AL-Go#391) Create
release action - CreateReleaseBranch error

### Changes to Pull Request Process
In v2.4 and earlier, the PullRequestHandler would trigger the CI/CD
workflow to run the PR build.
Now, the PullRequestHandler will perform the build and the CI/CD
workflow is only run on push (or manual dispatch)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
@mazhelez mazhelez mentioned this issue Feb 27, 2023
Merged
mazhelez added a commit to microsoft/ALAppExtensions that referenced this issue Feb 27, 2023
@mazhelez
Updated AL-Go System Files (#22270)
a332dc6 
## Preview

Note that when using the preview version of AL-Go for GitHub, you need
to Update your AL-Go system files, as soon as possible when told to do
so.

### Issues
- Issue [#391](microsoft/AL-Go#391) Create
release action - CreateReleaseBranch error

### Changes to Pull Request Process
In v2.4 and earlier, the PullRequestHandler would trigger the CI/CD
workflow to run the PR build.
Now, the PullRequestHandler will perform the build and the CI/CD
workflow is only run on push (or manual dispatch)

Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
@freddydk
Copy link
Collaborator

The root cause of this problem was that the Tag (which in the description needs to be SemVer compatible) was not SemVer compatible.
This caused one action to fail silently and subsequently another action to fail later.
In the next verson, the action will fail with a message that the Tag needs to be SemVer compatible version number.

@mazhelez mazhelez mentioned this issue Feb 28, 2023
Merged
aholstrup1 added a commit to microsoft/ALAppExtensions that referenced this issue Feb 28, 2023
@mazhelez @aholstrup1
Updated AL-Go System Files (#22412)
d273e6d 
## Preview

Note that when using the preview version of AL-Go for GitHub, you need
to Update your AL-Go system files, as soon as possible when told to do
so.

### Issues
- Issue [#391](microsoft/AL-Go#391) Create
release action - CreateReleaseBranch error

### Changes to Pull Request Process
In v2.4 and earlier, the PullRequestHandler would trigger the CI/CD
workflow to run the PR build.
Now, the PullRequestHandler will perform the build and the CI/CD
workflow is only run on push (or manual dispatch)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
@freddydk freddydk mentioned this issue Feb 28, 2023
Merged
@mazhelez mazhelez mentioned this issue Mar 6, 2023
Merged
@freddydk freddydk mentioned this issue Mar 6, 2023
Merged
@mazhelez mazhelez mentioned this issue Mar 7, 2023
Merged
mazhelez added a commit to microsoft/ALAppExtensions that referenced this issue Mar 7, 2023
@mazhelez
Updated AL-Go System Files (#22462)
fbf5ee1 
## Preview

Note that when using the preview version of AL-Go for GitHub, you need
to Update your AL-Go system files, as soon as possible when told to do
so.

### Issues
- Issue [#391](microsoft/AL-Go#391) Create
release action - CreateReleaseBranch error

### Changes to Pull Request Process
In v2.4 and earlier, the PullRequestHandler would trigger the CI/CD
workflow to run the PR build.
Now, the PullRequestHandler will perform the build and the CI/CD
workflow is only run on push (or manual dispatch)

### Build modes per project
Build modes can now be specified per project

### _DetermineProjectsToBuild_ action
A new action has been added to determine the projects to build.

The functionality was stripped from _ReadSettings_ action.

Note that if `useProjectDependencies` is set to `true`, you may need to
run _Update AL-Go System Files_ workflow twice.

Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
This was referenced Mar 8, 2023
Merged
Merged
This was referenced Mar 8, 2023
Merged
Merged
@mazhelez mazhelez mentioned this issue Mar 8, 2023
Merged
mazhelez added a commit to microsoft/ALAppExtensions that referenced this issue Mar 9, 2023
@mazhelez
Updated AL-Go System Files (#22488)
6175ea3 
## Preview

Note that when using the preview version of AL-Go for GitHub, you need
to Update your AL-Go system files, as soon as possible when told to do
so.

### **NOTE:** When upgrading to this version
When upgrading to this version form earlier versions of AL-Go for
GitHub, you will need to run the _Update AL-Go System Files_ workflow
twice if you have the `useProjectDependencies` setting set to _true_.

### Issues
- Issue [#391](microsoft/AL-Go#391) Create
release action - CreateReleaseBranch error

### Changes to Pull Request Process
In v2.4 and earlier, the PullRequestHandler would trigger the CI/CD
workflow to run the PR build.
Now, the PullRequestHandler will perform the build and the CI/CD
workflow is only run on push (or manual dispatch) and will perform a
complete build.

### Build modes per project
Build modes can now be specified per project

### New Actions
- **DetermineProjectsToBuild** is used to determine which projects to
build in PullRequestHandler, CI/CD, Current, NextMinor and NextMajor
workflows.
- **CalculateArtifactNames** is used to calculate artifact names in
PullRequestHandler, CI/CD, Current, NextMinor and NextMajor workflows.
- **VerifyPRChanges** is used to verify whether a PR contains changes,
which are not allowed from a fork.

Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
@mazhelez mazhelez mentioned this issue Mar 9, 2023
Merged
mazhelez added a commit to microsoft/ALAppExtensions that referenced this issue Mar 9, 2023
@mazhelez
Updated AL-Go System Files (#22501)
eaca79e 
## Preview

Note that when using the preview version of AL-Go for GitHub, you need
to Update your AL-Go system files, as soon as possible when told to do
so.

### **NOTE:** When upgrading to this version
When upgrading to this version form earlier versions of AL-Go for
GitHub, you will need to run the _Update AL-Go System Files_ workflow
twice if you have the `useProjectDependencies` setting set to _true_.

### Issues
- Issue [#391](microsoft/AL-Go#391) Create
release action - CreateReleaseBranch error

### Changes to Pull Request Process
In v2.4 and earlier, the PullRequestHandler would trigger the CI/CD
workflow to run the PR build.
Now, the PullRequestHandler will perform the build and the CI/CD
workflow is only run on push (or manual dispatch) and will perform a
complete build.

### Build modes per project
Build modes can now be specified per project

### New Actions
- **DetermineProjectsToBuild** is used to determine which projects to
build in PullRequestHandler, CI/CD, Current, NextMinor and NextMajor
workflows.
- **CalculateArtifactNames** is used to calculate artifact names in
PullRequestHandler, CI/CD, Current, NextMinor and NextMajor workflows.
- **VerifyPRChanges** is used to verify whether a PR contains changes,
which are not allowed from a fork.

Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
This was referenced Mar 22, 2023
Merged
Merged
@freddydk freddydk added Fix Ready Fix Ready Shipped Feature is included in the latest version labels Mar 30, 2023
@mazhelez mazhelez mentioned this issue Mar 30, 2023
Merged
aholstrup1 pushed a commit to microsoft/ALAppExtensions that referenced this issue Mar 31, 2023
@mazhelez
Updated AL-Go System Files (#22765)
c411d5b 
## Preview

Note that when using the preview version of AL-Go for GitHub, you need
to Update your AL-Go system files, as soon as possible when told to do
so.

### **NOTE:** When upgrading to this version
When upgrading to this version form earlier versions of AL-Go for
GitHub, you will need to run the _Update AL-Go System Files_ workflow
twice if you have the `useProjectDependencies` setting set to _true_.

### Issues
- Issue [#391](microsoft/AL-Go#391) Create
release action - CreateReleaseBranch error
- Issue 434 Building local DevEnv, downloading dependencies:
Authentication fails when using "gh auth status"

### Changes to Pull Request Process
In v2.4 and earlier, the PullRequestHandler would trigger the CI/CD
workflow to run the PR build.
Now, the PullRequestHandler will perform the build and the CI/CD
workflow is only run on push (or manual dispatch) and will perform a
complete build.

### Build modes per project
Build modes can now be specified per project

### New Actions
- **DetermineProjectsToBuild** is used to determine which projects to
build in PullRequestHandler, CI/CD, Current, NextMinor and NextMajor
workflows.
- **CalculateArtifactNames** is used to calculate artifact names in
PullRequestHandler, CI/CD, Current, NextMinor and NextMajor workflows.
- **VerifyPRChanges** is used to verify whether a PR contains changes,
which are not allowed from a fork.

Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
@TobiasWeidemann TobiasWeidemann mentioned this issue Apr 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Fix Ready Fix Ready Shipped Feature is included in the latest version
Projects
AL-Go for GitHub Roadmap
Status: ✅ v3.0
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #391 Create release action - CreateReleaseBranch error freddydk/AL-Go
2 participants
@freddydk @kennetlindberg