Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect role is define for 'View details' control. #2240

Closed
JasonAment opened this issue Dec 14, 2018 · 4 comments · Fixed by #4059
Closed

Incorrect role is define for 'View details' control. #2240

JasonAment opened this issue Dec 14, 2018 · 4 comments · Fixed by #4059
Assignees
Labels
Area-Accessibility Bugs around feature accessibility Bug Partner-MsftBotFramework Bugs related to Msft BotFramework integration with AdaptiveCards Platform-JavaScript Bugs or features related to the JavaScript renderer
Milestone

Comments

@JasonAment
Copy link

Please review the following bug for repro steps and video:
microsoft/BotFramework-WebChat#1350

@dclaux dclaux mentioned this issue Mar 18, 2019
6 tasks
@shalinijoshi19 shalinijoshi19 added Area-Accessibility Bugs around feature accessibility Bug HealthBotBlocker Partner-MsftBotFramework Bugs related to Msft BotFramework integration with AdaptiveCards Platform-JavaScript Bugs or features related to the JavaScript renderer labels Apr 10, 2020
@ghost ghost added the Triage-Needed label Apr 10, 2020
@ghost ghost added this to Needs triage in Bug Triage Apr 10, 2020
@shalinijoshi19 shalinijoshi19 self-assigned this Apr 10, 2020
@ghost ghost moved this from Needs triage to Investigate in Bug Triage Apr 12, 2020
@shalinijoshi19
Copy link
Member

@dclaux wasn't able to repro this real quick. @corinagum is this somethign that is still repro'ing for your team?

@corinagum
Copy link
Contributor

@shalinijoshi19, thanks for the ping. Asking @compulim to look into this one, he will get back to you. :)

@compulim
Copy link
Contributor

image

It is still repro.

AFAIK, if the action is a link, e.g. Action.OpenUrl, it should have role="link" instead of role="button".

BTW, quick way to test AC in Web Chat (we use AC 1.2.5):

  1. Navigate to https://compulim.github.io/webchat-loader/
  2. Select "4.8.0"
  3. Click on preset "[Public] MockBot"
  4. Click "Open Web Chat in a new window"
  5. Upload a JSON file with the AC

The AC card JSON we tested:

{
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "type": "AdaptiveCard",
    "version": "1.0",
    "speak": "<s>Your  meeting about \"Adaptive Card design session\"<break strength='weak'/> is starting at 12:30pm</s><s>Do you want to snooze <break strength='weak'/> or do you want to send a late notification to the attendees?</s>",
    "body": [
        {
            "type": "TextBlock",
            "text": "Adaptive Card design session",
            "size": "Large",
            "weight": "Bolder"
        },
        {
            "type": "TextBlock",
            "text": "Conf Room 112/3377 (10)",
            "isSubtle": true
        },
        {
            "type": "TextBlock",
            "text": "12:30 PM - 1:30 PM",
            "isSubtle": true,
            "spacing": "None"
        },
        {
            "type": "TextBlock",
            "text": "Snooze for"
        },
        {
            "type": "Input.ChoiceSet",
            "id": "snooze",
            "value": "5",
            "choices": [
                {
                    "title": "5 minutes",
                    "value": "5"
                },
                {
                    "title": "15 minutes",
                    "value": "15"
                },
                {
                    "title": "30 minutes",
                    "value": "30"
                }
            ]
        },
        {
            "type": "ActionSet",
            "actions": [
                {
                    "type": "Action.OpenUrl",
                    "title": "Action.OpenUrl",
                    "url": "https://microsoft.com/"
                }
            ]
        }
    ],
    "actions": [
        {
            "type": "Action.Submit",
            "title": "Snooze",
            "data": {
                "x": "snooze"
            }
        },
        {
            "type": "Action.Submit",
            "title": "I'll be late",
            "data": {
                "x": "late"
            }
        }
    ]
}

@shalinijoshi19 shalinijoshi19 added this to To do: Milestone: Accessibility - JS - Address HealthBot Blocker bugs in Accessibility Updates for v1.* codebase May 1, 2020
@paulcam206 paulcam206 moved this from To do: JS - HealthBot Blocker bugs (Move items from here to current milestone column as part of planning to begin each sprint) to In progress in Accessibility Updates for v1.* codebase May 27, 2020
Bug Triage automation moved this from Investigate to Closed May 27, 2020
Accessibility Updates for v1.* codebase automation moved this from In progress to Done May 27, 2020
paulcam206 added a commit that referenced this issue May 29, 2020
Fixes #3914 in release/1.2 (this is also the PR)
Fixes #2240 in release/1.2 (PR #4059)
paulcam206 added a commit that referenced this issue May 29, 2020
Fixes #3914 in release/1.2 (this is also the PR)
Fixes #2240 in release/1.2 (PR #4059)
@ghost
Copy link

ghost commented Jun 1, 2020

🎉AdaptiveCards@v1.2.9 has been released which fixes this issue.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Bug Partner-MsftBotFramework Bugs related to Msft BotFramework integration with AdaptiveCards Platform-JavaScript Bugs or features related to the JavaScript renderer
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants