Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Teams][Accessibility][FactSet table being read column by column instead of row by row] #5206

Closed
1 task
lindach167 opened this issue Dec 19, 2020 · 4 comments · Fixed by #6223
Closed
1 task

[Teams][Accessibility][FactSet table being read column by column instead of row by row] #5206

lindach167 opened this issue Dec 19, 2020 · 4 comments · Fixed by #6223
Assignees
@jwoo-msft
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Projects
Current Sprint Triage

Comments

@lindach167
Copy link

lindach167 commented Dec 19, 2020 •
edited by RebeccaAnne

FactSet.mp4

FactSetJson.txt

Platform

  • iOS

Author or host

Host - Teams Mobile

Version of SDK

1.2

Details

This is a ship blocking issue for an app that is aiming to release on Teams Platform. Please see attached video and adaptive card JSON. The issue is that when swiping through the FactSet table using TalkBack, the entirely of the left column is read, and then the values on the right column is read. This makes it very difficult for accessibility users to associate with the label with the actual value. The expected result is that each row is read one by one, ie: "Accrural Rate", "120.00...", "Carry Forward", "0 hours", etc.

This does not repro on Android or Web, it is working as expected there.
@lindach167 lindach167 added the Bug label Dec 19, 2020
@ghost ghost added this to the 21.01 milestone Dec 19, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Dec 19, 2020
@ghost
Copy link

ghost commented Dec 19, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@ghost ghost added this to Needs triage in Bug Triage Dec 19, 2020
@ghost ghost added the AdaptiveCards v21.01 label Dec 19, 2020
@ghost ghost moved this from Needs triage to Approved in Bug Triage Jan 12, 2021
@jwoo-msft
Copy link
Member

jwoo-msft commented Jan 13, 2021 •
edited

@lindach167,
cc. @RebeccaAnne & @shalinijoshi19 for visibility
This is fixed in our latest release (renderer version 2.4.) that is being integrated to Teams, and I doubled checked that it works.

FactSetAccessibility.mov

Bug Triage automation moved this from Approved to Closed Jan 13, 2021
@lindach167
Copy link
Author

Thanks Joeseph!

@jwoo-msft jwoo-msft reopened this Jan 30, 2021
Bug Triage automation moved this from Closed to Needs triage Jan 30, 2021
@jwoo-msft
Copy link
Member

jwoo-msft commented Jan 30, 2021 •
edited

re-opening, this issue is reproducible in some devices. we have to explicitly group a fact and value in the same row.

@jwoo-msft jwoo-msft moved this from Needs triage to Approved in Bug Triage Jan 30, 2021
@jwoo-msft jwoo-msft modified the milestones: 21.01, Short Term Jan 30, 2021
@jwoo-msft jwoo-msft added Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) High Priority labels Apr 26, 2021
@RebeccaAnne RebeccaAnne removed this from the Short Term milestone May 6, 2021
@jonmill jonmill added this to the 21.08 milestone Jul 26, 2021
jwoo-msft added a commit that referenced this issue Aug 18, 2021
@jwoo-msft
[ios] fixed #5206
ad39f22
@jwoo-msft jwoo-msft mentioned this issue Aug 18, 2021
Merged
@jonmill jonmill added this to To do in Current Sprint via automation Aug 19, 2021
@jonmill jonmill moved this from To do to Review in progress in Current Sprint Aug 19, 2021
@jonmill jonmill removed this from Approved in Bug Triage Aug 19, 2021
@jonmill jonmill added this to Committed in Triage Aug 20, 2021
Triage automation moved this from Committed to Closed Aug 25, 2021
jwoo-msft added a commit that referenced this issue Aug 25, 2021
@jwoo-msft @almedina-ms
[ios] fixed #5206 (#6223)
ba70032 
Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Current Sprint automation moved this from Review in progress to Done Aug 25, 2021
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this issue Nov 10, 2022
@jwoo-msft @almedina-ms @michaelfarnsworth
[ios] fixed microsoft#5206 (microsoft#6223)
63e4cbf 
Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this issue May 8, 2024
@jwoo-msft @almedina-ms
[ios] fixed microsoft#5206 (microsoft#6223)
f5ad80e 
Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwoo-msft jwoo-msft

Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Projects
Current Sprint
  
Done
Triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ios] fixed #5206 microsoft/AdaptiveCards
4 participants
@jonmill @jwoo-msft @RebeccaAnne @lindach167