[Authoring] [dotnet] AdaptiveRefresh class does not serialize correctly

[pschaeflein]

Target Application

BotFramework

Application Operating System

Windows

Schema Version

1.4

Problem Description

An adaptive card that has a refresh attribute is not serialized correctly. The Action and UserIds properties are serialized in initial case instead of lower case.

When the card is sent as an attachment in BotFramework, the response indicates an error:

{
  error: {
    code: 'BadSyntax', 
    message: 'Payload is incorrect' 
  }
}

Expected Outcome

{
  "type": "AdaptiveCard",
  "version": "1.4",
  "body": [
    {
      "type": "TextBlock",
      "size": "medium",
      "weight": "bolder",
      "text": "AdaptiveRefreshSerializeBug",
      "wrap": true,
      "style": "heading"
    }
  ],
  "refresh": {
    "action": {
      "type": "Action.Execute",
      "verb": "refresh",
      "title": "Refresh"
    },
    "userIds": [
      "testUser"
    ]
  }
}

Actual Outcome

{
  "type": "AdaptiveCard",
  "version": "1.4",
  "body": [
    {
      "type": "TextBlock",
      "size": "medium",
      "weight": "bolder",
      "text": "AdaptiveRefreshSerializeBug",
      "wrap": true,
      "style": "heading"
    }
  ],
  "refresh": {
    "Action": {
      "type": "Action.Execute",
      "verb": "refresh",
      "title": "Refresh"
    },
    "UserIds": [
      "testUser"
    ]
  }
}

Card JSON

If the card JSON is adjusted to the Actual Outcome, rendering is correct.

Repro Steps

The following console application demonstrates the bug. Compare the output to the const:

using AdaptiveCards;
using System;

namespace AdaptiveRefreshSerializeBug
{
  class Program
  {
    public const string RefreshCard = @"
{
  ""$schema"": ""http://adaptivecards.io/schemas/adaptive-card.json"",
  ""type"": ""AdaptiveCard"",
  ""version"": ""1.4"",
  ""refresh"": {
    ""action"": {
      ""type"": ""Action.Execute"",
      ""title"": ""Refresh"",
      ""verb"": ""refresh""
    },
    ""userIds"": [""testUser""]
  },
  ""body"": [
    {
      ""type"": ""TextBlock"",
      ""size"": ""Medium"",
      ""weight"": ""Bolder"",
      ""text"": ""AdaptiveRefreshSerializeBug"",
      ""wrap"": true,
      ""style"": ""heading""
    }
  ]
}";


    static void Main(string[] args)
    {
      var card = AdaptiveCard.FromJson(RefreshCard);

      Console.WriteLine(card.Card.ToJson());
    }
  }
}

[ghost]

Many of our core contributors are taking some much needed vacation time throughout December 2021. Thank you for being patient while we recharge and return to normal responsiveness in January 2022. In the meantime, please feel free to continue to pose questions, open issues, and make feature requests - you may not get a response right away, but we'll reply once we're back in January. Thanks!

[pschaeflein]

Since you are looking at serialization, can I kindly ask you re-visit #4716?

[Greg-Hitchon]

happy to see work on this! spent more time than I should have trying to figure out what was happening before I found the root cause and this issue.