Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Freeway-Bug}[Adaptive Cards - Blog]: Elements marked as presentational should not have global ARIA or tabindex to ensure all screen readers ignore them. #8542

Closed
vagpt opened this issue Jun 9, 2023 · 5 comments · Fixed by #8713
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance Area-Accessibility Bugs around feature accessibility Area-Renderers Bug HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization HCL-E+D Product-AC
Projects

Comments

@vagpt
Copy link
Collaborator

vagpt commented Jun 9, 2023

Target Platforms

Other

SDK Version

1.5

Application Name

Adaptive Cards

Problem Description

Test Environment:
OS: Version 23H2 (OS Build 25381.1)
URL: https://adaptivecards.io/blog/
Browser: Edge Dev Version 115.0.1880.3 (Official build) dev (64-bit)
Tool: Accessibility Insight For Web

Repro Steps:

  1. Open the above URL in the edge dev browser.
  2. Navigate to 'Blog' tab item and press enter key to activate it.
  3. Run the AI Tool and observe the issue.

Actual Result:
Elements marked as presentational have global ARIA or tabindex.

Expected Result:
Elements marked as presentational should not have global ARIA or tabindex to ensure all screen readers ignore them

Element path:
.w3-cell-row.w3-padding-16:nth-child(1) > article:nth-child(1) > .w3-margin-top > .w3-cell-middle.w3-cell > a[href$="adaptivecards.io"][role="presentation"]

How to fix:
Fix all of the following:
Element is not focusable.

Note:
This issue is repro throughout the Blog screen.

User Impact:
It will impact the AT user if the element marked as presentational have Global Aria or Tab Index.

WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships

“Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com)

Screenshots

WCAG1 3 1-Elements marked as presentational should not have global ARIA or tabindex to ensure all screen readers ignore them

image

Card JSON

NA

Sample Code Language

No response

Sample Code

No response

@vagpt vagpt added Bug Area-Renderers Area-Accessibility Bugs around feature accessibility A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yWCAG Accessibility issue that affects compliance HCL-E+D Product-AC HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization labels Jun 9, 2023
@github-actions github-actions bot added this to Not Triaged in Triage Jun 9, 2023
Triage automation moved this from Not Triaged to Closed Oct 19, 2023
@vagpt
Copy link
Collaborator Author

vagpt commented Oct 19, 2023

Hi @anna-dingler,

Could you please let us know by when the changes will be reflected on the prod so that we can reverify this issue at our end as of now this issue is still repro at our end.

Snippet:
image

@anna-dingler
Copy link
Contributor

Hi @vagpt, we are planning to make a release at the end of the month.

@vagpt
Copy link
Collaborator Author

vagpt commented Oct 20, 2023

Hi @anna-dingler,

Thanks for the confirmation.

Due to this issue (#8542) and #8541, Adaptive Cards product grade is getting impacted currently it is in Grade D so it would be great if you can release before 26/10/23 so that we can regress this issue and close both issues.

@anna-dingler
Copy link
Contributor

Hi @vagpt , a new version of the website was just released!

@vagpt
Copy link
Collaborator Author

vagpt commented Oct 30, 2023

Thanks @anna-dingler,

Now this issue is working fine on the environment below, hence adding A11yTTValidated tag.

Test Environment:
OS: Version 23H2 (OS Build 25967.1010)
URL: https://adaptivecards.io/blog/
Browser: Edge Dev Version 120.0.2172.1 (Official build) dev (64-bit)
Tool: Accessibility Insight For Web

Snippet:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance Area-Accessibility Bugs around feature accessibility Area-Renderers Bug HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization HCL-E+D Product-AC
Projects
Triage
Closed
Development

Successfully merging a pull request may close this issue.

2 participants