[Android] Fix to time preparsing returning invalid value #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almedina-ms
changed the title
almedina-ms
added a commit
that referenced
this pull request
May 22, 2018
almedina-ms
added a commit
that referenced
this pull request
May 22, 2018
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix to this #1371
It looks like the method wcsftime didn't work in SDK 19 always returning a "%" which in turn messed the string to integer conversion and made the program crash, I changed the function to strftime which is the same function, with the only difference that the former uses single byte chars