[DevSpec] Underline #3277
[DevSpec] Underline #3277
Conversation
almedina-ms
requested review from
matthidinger,
jwoo-msft,
RebeccaAnne,
andrewleader,
paulcam206 and
shalinijoshi19
|
|
||
| ### Samples | ||
| The following samples will be added to validate rendering: | ||
| - TextBlock.Underline.json file which contains TextBlock with underline |
There was a problem hiding this comment.
In the proposal review and the spec, we decided to only add underline to TextRun. Whether we add the property to TextBlock (and all other TextRun properties to TextBlock) needs further discussion.
There was a problem hiding this comment.
Who is requesting this feature again and are they only requesting it for TextRun or also TextBlocks? What is the estimated cost for adding underllines to TextBlock as well? If not significant should we just include it if it makes sense and facilitates usability of the feature (so the customer doesnt have to remember which one to pick that has underline support) ?
There was a problem hiding this comment.
The customer only needs it for underline, and we had a disagreement about whether features in TextRun should also be on TextBlock, that disagreement needs to be solved before we add this feature to TextBlock (Matt and David disagreed with adding underline to TextBlock).
ghost
added
the
specs/DevSpecs/TextRun.Underline.md
Outdated
|
|
||
| ### UWP & .NET WPF | ||
|
|
||
| TextBlock has a property called [TextDecorations](https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.textblock.textdecorations) which includes Underline |
There was a problem hiding this comment.
TextBlock [](start = 0, length = 9)
update actual type #Closed
|
@almedina-ms / @andrewleader, are we able to now close this PR out given the code itself has been merged? |
|
Seems good to merge/close, the spec for underline should also be merged into master if the feature is coded up everywhere: #3086 |
|
This Pull request has had no recent activity for the past 2 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
@almedina-ms this now goes into spec\designDiscussions ; Let;s get this checked in. |
…m/microsoft/AdaptiveCards into user/almedina-ms/DevSpecUnderline
This is the devspec for underline
Microsoft Reviewers: Open in CodeFlow