Avoid unnecessary std::shared_ptr copies #4212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue, to avoid unnecessary reference count changes.
chriche-ms
changed the title
…com/chriche-ms/AdaptiveCards into chriche/uwp_performance_sharedmodel
shalinijoshi19
added
the
Area-Performance
|
@almedina-ms is added to the review. #Closed |
|
@paulcam206 is added to the review. #Closed |
|
@RebeccaAnne is added to the review. #Closed |
ghost
added
the
|
Hi @chriche-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
…com/chriche-ms/AdaptiveCards into chriche/uwp_performance_sharedmodel
|
Hi @chriche-ms; Thanks for taking action on your previously stale pull request. Resetting staleness. |
…com/chriche-ms/AdaptiveCards into chriche/uwp_performance_sharedmodel
|
Hi @chriche-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
paulcam206
approved these changes
Jul 7, 2020
|
Hi @paulcam206; Thanks for reviewing this previously stale pull request. Resetting staleness. @chriche-ms FYI. |
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Change std::shared_ptr parameters to be const-ref, rather than by value, to avoid unnecessary reference count changes. * Update GetSharedModel and related function to minimize shared_ptr ownership changes * Update Java interop code Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #4211
Description
This PR updates various frequently called functions in order to minimize the frequency with which ownership of various std::shared_ptr variables is shared. Instead the variables are either passed by reference (instead of by value) or ownership is transferred using std::move.
How Verified
Existing unit tests were successfully run.
Microsoft Reviewers: Open in CodeFlow