Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Convert to nuget version of cppwinrt #4319

Merged
merged 3 commits into from
Jul 8, 2020
Merged

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented Jul 7, 2020

Description

Needed in order to continue using C++/WinRT on more recent Windows SDKs.

Changes required:

  • Add Microsoft.Windows.CppWinRT nuget package
  • Remove manual calls to mdmerge (this is handled by cppwinrt now)
  • Add missing default_interface directives to various renderer runtimeclasses

Some decent benefits here (apart from having access to newer cppwinrt functionality):

  • When we target a new Windows SDK, we will no longer have to maintain our custom mdmerge build step
  • Since mdmerge is handled automatigically, build/debug is more seamless -- the custom step is no longer run every single time

How Verified

  • tested converting a small piece of code over to cppwinrt style then building/testing
Microsoft Reviewers: Open in CodeFlow

Needed in order to continue using C++/WinRT on more recent SDKs.

Changes required:
* Add `Microsoft.Windows.CppWinRT` nuget package
* Remove manual calls to `mdmerge` (this is handled by cppwinrt now)
* Add missing `default_interface` directives to various renderer runtimeclasses
@paulcam206 paulcam206 added the Platform-XAML Bugs or features related to Xaml Renderer label Jul 7, 2020
Copy link
Contributor

@RebeccaAnne RebeccaAnne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@paulcam206 paulcam206 merged commit c2e62be into main Jul 8, 2020
@paulcam206 paulcam206 deleted the paulcam/cppwinrt-2.0 branch July 8, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform-XAML Bugs or features related to Xaml Renderer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants