Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ACRToggleInputView.h to public header list #4327

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Jul 8, 2020

Related Issue

None

Description

ACRToggleInputView.h is a new header that owns ACRToggleInputView.xib. This change adds the header to the public header list, so it can be custom rendered when XIB is not used.

How Verified

How you verified the fix, including one or all of the following:

  1. New unit test is added to check that the new view is available for customization.
  2. Unit tests are run
Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@shalinijoshi19 shalinijoshi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jwoo-msft jwoo-msft merged commit 743d477 into main Jul 8, 2020
@jwoo-msft jwoo-msft deleted the jwoo/ios-project-file-update branch July 8, 2020 20:11
jwoo-msft added a commit that referenced this pull request Jul 8, 2020
* added ACRToggleInputView.h to public header list

* added unit test and added the new hearder to umbrella header for easy
access for developer
jwoo-msft added a commit that referenced this pull request Jul 8, 2020
* added ACRToggleInputView.h to public header list (#4327)

* added ACRToggleInputView.h to public header list

* added unit test and added the new hearder to umbrella header for easy
access for developer

* updated sample app

* reversed target name change for uitest
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* added ACRToggleInputView.h to public header list

* added unit test and added the new hearder to umbrella header for easy
access for developer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants