Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back Porting Sample App changes from release/1.2 #4333

Merged
merged 3 commits into from
Jul 10, 2020
Merged

Back Porting Sample App changes from release/1.2 #4333

merged 3 commits into from
Jul 10, 2020

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Jul 9, 2020 •
edited by ghost

Related Issue

None

Description

  • increased text size for the payload editing window
  • changed keyboard type to allow double quotes to be accepted, with default keyboard, double quote leads to char value that's invalid char for our JSON parser.
  • added error AdaptiveCards UI when parsing fails.
  • added dismiss button to the keyboard of the editing window.

How Verified

  1. Unit Test against regression test.
  2. visual examination of sample app
Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft merged commit db2bd86 into main Jul 10, 2020
@jwoo-msft jwoo-msft deleted the jwoo/ios-sample-app-update branch July 10, 2020 02:32
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
@jwoo-msft
Back Porting Sample App changes from release/1.2 (microsoft#4333)
6f4c231 
* updated sample app

* reversed target name change for uitest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcam206 paulcam206 paulcam206 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwoo-msft @paulcam206